Conversation
tonyredondo
force-pushed
the
tony/cache-experiment
branch
from
754cb91 to
4352c13
Compare
tonyredondo
force-pushed
the
tony/cache-experiment
branch
from
7c496ea to
82fa8a1
Compare
anmarchenko
approved these changes
May 19, 2025
| description: 'If provided, only the specified build systems will be instrumented (allowed values are `gradle` and `maven`). Otherwise every Java process will be instrumented.' | ||
| required: false | ||
| cache: | ||
| description: 'Enable caching (optional). Defaults to true.' |
Member
There was a problem hiding this comment.
let's add here that caching only works for Go
Member
Author
There was a problem hiding this comment.
I'm planning to support dotnet as well in the next PR.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables caching for Go auto-instrumentation.
Motivation
Processing, pinning and applying the Go instrumentation requires time to download all the orchestrion and dd-trace-go dependencies.
By enabling cache, we can reduce the time to apply autoinstrumentation.
In this example we were able to reduce the job time from 4min 48sec to 1min and 15secs. aprox.
Additional Notes
A new
cacheinput was added to the action, the default value istruebut you can disable the cache by setting the key tofalse.Possible Drawbacks / Trade-offs
Describe how to test/QA your changes